DRY: remove dead code and deduplicate patterns#25
Open
clockblocker wants to merge 5 commits intomasterfrom
Open
DRY: remove dead code and deduplicate patterns#25clockblocker wants to merge 5 commits intomasterfrom
clockblocker wants to merge 5 commits intomasterfrom
Conversation
Add CODEOWNERS and docs/ARCHITECTURE.md to define 5 logical ownership domains: plugin-core, commands, ai-api, prompt-engineering, and filesystem. Each source file maps to exactly one domain with no overlapping patterns. Nightshift-Task: ownership-boundary Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Delete 3 dead files: wip_keymaker.ts, full-dict-enrtie.ts, endgame.ts (~879 lines) - Fix insertReplyFromKeymaker import pointing to wrong module (C1Richter) - Extract blockOrEmpty helper to replace 4 identical longDash checks in fillTemplate.ts - Deduplicate 5 selection-based command registrations in main.ts into data-driven loop - Remove unused deepseekApiKey from types.ts and settings.ts - Remove debug console.log statements from utils.ts Nightshift-Task: auto-dry Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add Notice('Generating…') spinner to all 6 AI-powered commands
(fillTemplate, normalizeSelection, translateSelection,
insertReplyFromKeymaker, insertReplyFromC1Richter,
getInfinitiveAndEmoji) with proper cleanup in finally blocks
- Add 30-second timeout to API calls via Promise.race in
generateContent() to prevent indefinite hangs on network issues
- Replace console.error with Notice in insertReplyFromC1Richter
error handler for consistent user-facing error reporting
Nightshift-Task: idea-generator
Nightshift-Ref: https://github.com/marcus/nightshift
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Remove unused imports: z, HarmCategory, HarmBlockThreshold, ResponseSchema, TFile, TAbstractFile, requestUrl - Remove dead startTime/endTime/duration timing variables - Fix chatKey to include responseSchema flag, preventing cache collisions between JSON and text responses - Remove unused MarkdownView import from getInfinitiveAndEmoji.ts Nightshift-Task: idea-generator Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add loading spinners and API timeout to commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wip_keymaker.ts,full-dict-enrtie.ts,endgame.tsinsertReplyFromKeymakerimport bug (was silently loading C1Richter module)blockOrEmptyhelper infillTemplate.tsto replace 4 identical longDash checksmain.tsinto a data-driven loopdeepseekApiKeyfromtypes.tsandsettings.tsconsole.logstatements fromutils.tsTest plan
tsc -noEmitpassesesbuildproduction build succeeds🤖 Generated with Claude Code